Repository navigation
chore: add local DCO sign-off check - #1359
Closed
gjermundgaraba wants to merge 12 commits into
Closed
gjermundgaraba wants to merge 12 commits into
gjermundgaraba wants to merge 12 commits into
Conversation
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
gjermundgaraba
changed the title
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
gjermundgaraba
changed the title
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
gjermundgaraba
marked this pull request as ready for review
August 12, 2026 20:43
Contributor
Greptile SummaryThe PR adds an optional local DCO commit hook, regression coverage in CI, and contributor installation and recovery instructions.
Confidence Score: 4/5The PR is not yet safe to merge because the documented installation can silently leave the DCO hook inactive for contributors using core.hooksPath. The updated command fixes the linked-worktree case but still copies into the common Git directory even when Git is configured to execute hooks from another path. Files Needing Attention: spec/CONTRIBUTING.md Important Files Changed
Reviews (2): Last reviewed commit: "docs: support worktrees when installing ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commit-msghook that rejects non-merge commits without the committer's DCO sign-offWhy
The repository's DCO check reports missing sign-offs after a push. This hook gives contributors the same feedback before creating a commit without automatically making the legal attestation for them.
Verification
.githooks/test-commit-msg---divider and customtrailer.separatorsshellcheck .githooks/commit-msg .githooks/test-commit-msgmake check-license-headersgit diff --check